TouK / nussknacker

Low-code tool for automating actions on real time data | Stream processing for the users.
https://nussknacker.io
Apache License 2.0
657 stars 93 forks source link

[1.18][NU-1772] Scenario activities fixes #7134

Open mgoworko opened 5 days ago

mgoworko commented 5 days ago

Describe your changes

Fixes related to Scenario Activities:

  1. Comments that contain only spaces are now handled as ScenarioComment.WithoutContent. Refactored, in order to implement validation in a single place.

  2. AutomaticUpdate activity is now only added for scenario, when at least one migration actually applies to that particular scenario (before this fix, the AutomaticUpdate was added for all scenarios when migrations were applied).

  3. Fixed activities of periodic deployment manager:

    • only finished (with success or with error) data processing should be shown as activity, not deployment errors
    • added tests

Checklist before merge