Closed Dzuming closed 6 days ago
The changes in this pull request involve modifications to several components related to the Ace editor. A new optional property, enableLiveAutocompletion
, is introduced across multiple files, enhancing the configurability of live autocompletion features. The AceWrapper
component is updated to dynamically pass this property to the Ace editor, while the CustomCompleterAceEditor
component is modified to accept and destructure this new property. Additionally, the MarkdownFormControl
component is updated to set the enableLiveAutocompletion
prop to false
. A typographical error in variable naming is also corrected.
File | Change Summary |
---|---|
designer/client/src/components/graph/node-modal/editors/expression/AceWrapper.tsx |
Added enableLiveAutocompletion?: boolean to AceWrapperProps . Corrected variable name from DEFAULF_EDITOR_PROPS to DEFAULT_EDITOR_PROPS . Updated function signature to include the new prop. |
designer/client/src/components/graph/node-modal/editors/expression/CustomCompleterAceEditor.tsx |
Added enableLiveAutocompletion?: boolean to CustomCompleterAceEditorProps . Updated component to destructure and pass this prop to AceEditor . |
designer/client/src/components/graph/node-modal/editors/field/MarkdownFormControl.tsx |
Added enableLiveAutocompletion prop to CustomCompleterAceEditor , set to false . |
sequenceDiagram
participant User
participant MarkdownFormControl
participant CustomCompleterAceEditor
participant AceWrapper
participant AceEditor
User->>MarkdownFormControl: Interacts with editor
MarkdownFormControl->>CustomCompleterAceEditor: Passes props including enableLiveAutocompletion
CustomCompleterAceEditor->>AceWrapper: Passes props to AceWrapper
AceWrapper->>AceEditor: Sets options with enableLiveAutocompletion
🐰 "In the code where rabbits hop,
Live autocompletion, we can't stop!
With props that dance and play so bright,
Our editor's now a joyful sight!
So let's celebrate with a little cheer,
For changes made, we hold so dear!" 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Describe your changes
Before:
https://github.com/user-attachments/assets/d869d7ff-c9cf-41ac-9b18-7fcaa0111d51
After:
https://github.com/user-attachments/assets/908fb757-6acf-4ff6-b64b-3835bb7a5194
Checklist before merge
Summary by CodeRabbit
New Features
enableLiveAutocompletion
property for enhanced configurability in the Ace editor components.Bug Fixes
Documentation