TouK / nussknacker

Low-code tool for automating actions on real time data | Stream processing for the users.
https://nussknacker.io
Apache License 2.0
664 stars 93 forks source link

[NU-1891] remove autocompletion from markdown editors #7178

Closed Dzuming closed 6 days ago

Dzuming commented 1 week ago

Describe your changes

Before:

https://github.com/user-attachments/assets/d869d7ff-c9cf-41ac-9b18-7fcaa0111d51

After:

https://github.com/user-attachments/assets/908fb757-6acf-4ff6-b64b-3835bb7a5194

Checklist before merge

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes in this pull request involve modifications to several components related to the Ace editor. A new optional property, enableLiveAutocompletion, is introduced across multiple files, enhancing the configurability of live autocompletion features. The AceWrapper component is updated to dynamically pass this property to the Ace editor, while the CustomCompleterAceEditor component is modified to accept and destructure this new property. Additionally, the MarkdownFormControl component is updated to set the enableLiveAutocompletion prop to false. A typographical error in variable naming is also corrected.

Changes

File Change Summary
designer/client/src/components/graph/node-modal/editors/expression/AceWrapper.tsx Added enableLiveAutocompletion?: boolean to AceWrapperProps. Corrected variable name from DEFAULF_EDITOR_PROPS to DEFAULT_EDITOR_PROPS. Updated function signature to include the new prop.
designer/client/src/components/graph/node-modal/editors/expression/CustomCompleterAceEditor.tsx Added enableLiveAutocompletion?: boolean to CustomCompleterAceEditorProps. Updated component to destructure and pass this prop to AceEditor.
designer/client/src/components/graph/node-modal/editors/field/MarkdownFormControl.tsx Added enableLiveAutocompletion prop to CustomCompleterAceEditor, set to false.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant MarkdownFormControl
    participant CustomCompleterAceEditor
    participant AceWrapper
    participant AceEditor

    User->>MarkdownFormControl: Interacts with editor
    MarkdownFormControl->>CustomCompleterAceEditor: Passes props including enableLiveAutocompletion
    CustomCompleterAceEditor->>AceWrapper: Passes props to AceWrapper
    AceWrapper->>AceEditor: Sets options with enableLiveAutocompletion

🐰 "In the code where rabbits hop,
Live autocompletion, we can't stop!
With props that dance and play so bright,
Our editor's now a joyful sight!
So let's celebrate with a little cheer,
For changes made, we hold so dear!" 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.