TouK / nussknacker

Low-code tool for automating actions on real time data | Stream processing for the users.
https://nussknacker.io
Apache License 2.0
664 stars 93 forks source link

1.18 ports5 #7209

Closed arkadius closed 5 days ago

arkadius commented 5 days ago

Describe your changes

Checklist before merge

Summary by CodeRabbit

Release Notes

coderabbitai[bot] commented 5 days ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces several modifications across multiple components in the Nussknacker codebase. Key changes include the renaming of the `RequireValueFromEmptyFixedList` case class to `EmptyFixedListForRequiredField` within the `ProcessCompilationError` hierarchy, which affects error handling related to compilation errors but retains the same functionality. A new `FromJsonDecoder` object has been added, featuring a method `jsonToAny` that converts JSON objects into Scala types, enhancing JSON handling capabilities. The `ValueDecoder` object has been updated to improve the handling of missing fields in JSON records, allowing for a more robust decoding process. Additionally, various test classes have been introduced or modified to ensure comprehensive coverage of the new and updated functionalities, particularly focusing on JSON decoding and validation logic. Other changes include updates to UI components for better user feedback and the integration of internationalization support. Overall, the changes reflect a significant enhancement in error handling, JSON processing, and user interface interactions. ## Possibly related PRs - **#7124**: This PR enhances documentation related to casting and conversions, which may indirectly relate to the changes in `ProcessCompilationError` as it involves type handling. - **#7159**: This PR modifies the `FlinkTestMainSpec.scala` to improve testing for fragments with parameter validation, which could relate to the error handling in `ProcessCompilationError`. - **#7166**: This PR addresses the `assignUserFriendlyEditor` method, which may involve similar validation logic as seen in `ProcessCompilationError`. - **#7171**: This PR updates validation messages for input parameters, which aligns with the changes in error handling in `ProcessCompilationError`. - **#7182**: This PR improves validation for scenario labels, which could relate to the error handling aspect of `ProcessCompilationError`. - **#7183**: This PR modifies the visibility of categories based on conditions, which may relate to the overall error handling and validation logic in the application. - **#7187**: This PR addresses validation issues when using literal lists with mixed types, which is directly relevant to the changes in `ProcessCompilationError`. - **#7190**: This PR fixes validation errors when referencing non-existing fragments, which relates to error handling in `ProcessCompilationError`. - **#7193**: This PR adds tooltips for various components, enhancing user feedback, which is relevant to the error handling and user experience aspects of `ProcessCompilationError`. ## Suggested reviewers - ZbyszekMM

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between e440a865f0f766266a6957777d72535e44e7d4bf and e122eff4d7d54c705ab27018632b8c4a59c1eef2.
📒 Files selected for processing (1) * `scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/ProcessCompilerData.scala` (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/compile/ProcessCompilerData.scala

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.