TouK / sputnik

Static code review for your Gerrit patchsets. Runs Checkstyle, PMD, FindBugs, Scalastyle, CodeNarc, JSLint for you!
Apache License 2.0
201 stars 117 forks source link

Move Gerrit comment filter to after visitor #211

Closed SpOOnman closed 4 years ago

SpOOnman commented 4 years ago

Fixes #208

codecov-io commented 4 years ago

Codecov Report

Merging #211 into master will increase coverage by 1.49%. The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     72.11%   73.61%   +1.49%     
- Complexity      601      613      +12     
============================================
  Files           145      145              
  Lines          1944     1952       +8     
  Branches        127      128       +1     
============================================
+ Hits           1402     1437      +35     
+ Misses          485      457      -28     
- Partials         57       58       +1
Impacted Files Coverage Δ Complexity Δ
...a/pl/touk/sputnik/connector/local/LocalFacade.java 71.79% <ø> (ø) 7 <0> (ø) :arrow_down:
...k/sputnik/connector/gerrit/ReviewInputBuilder.java 100% <ø> (ø) 6 <0> (-3) :arrow_down:
...ain/java/pl/touk/sputnik/engine/diff/FileDiff.java 100% <ø> (ø) 4 <0> (?)
src/main/java/pl/touk/sputnik/engine/Engine.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../sputnik/connector/gerrit/GerritFacadeBuilder.java 13.04% <0%> (+2.32%) 2 <0> (ø) :arrow_down:
...pl/touk/sputnik/connector/gerrit/GerritFacade.java 47.36% <0%> (-7.18%) 8 <0> (ø)
...k/engine/visitor/comment/GerritCommentVisitor.java 100% <100%> (ø) 9 <9> (?)
.../engine/visitor/comment/GerritFileDiffBuilder.java 78.57% <100%> (ø) 4 <1> (?)
.../visitor/comment/GerritFileDiffBuilderWrapper.java 75% <75%> (ø) 5 <5> (?)
...in/java/pl/touk/sputnik/engine/VisitorBuilder.java 97.72% <87.5%> (-2.28%) 16 <2> (+2)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04ca40c...4f97f12. Read the comment docs.