search

TouK / sputnik

Static code review for your Gerrit patchsets. Runs Checkstyle, PMD, FindBugs, Scalastyle, CodeNarc, JSLint for you!
Apache License 2.0
201 stars 117 forks source link

Bump Detekt version from 1.0.0-RC14 to 1.8.0 #218

Closed snooze92 closed 4 years ago

snooze92 commented 4 years ago

RC changelog (https://arturbosch.github.io/detekt/changelog-rc.html) includes the change from filters to includes/excludes in the rules. More details on this particular migration are here: https://arturbosch.github.io/detekt/howto-migratetestpattern.html

Another RC change replaced warningThreshold and failThreshold with maxIssues, but Sputnik has its own scoring strategy.

Since 1.0.0 (https://arturbosch.github.io/detekt/changelog.html) the changelog includes nice "notable changes" but no migration that would cause backward compatibility issue.

snooze92 commented 4 years ago

Marking as draft until I fix the build.

snooze92 commented 4 years ago

Closing. I was way too naive with this, did not expect dependency conflicts with ktlint.

SpOOnman commented 4 years ago

Can you work on this further and resolve conflicts?

snooze92 commented 4 years ago

I would love to, but I can't commit to being able to do so anytime soon.

snooze92 commented 4 years ago

Expanded my scope to bumping all Kotlin-related dependencies: https://github.com/TouK/sputnik/pull/225

snooze92 commented 4 years ago

@SpOOnman Any chance of checking out #225 ? 🎉