Closed corebonts closed 3 years ago
Merging #222 into master will increase coverage by
1.79%
. The diff coverage is76.00%
.
@@ Coverage Diff @@
## master #222 +/- ##
============================================
+ Coverage 73.25% 75.05% +1.79%
- Complexity 612 629 +17
============================================
Files 146 147 +1
Lines 1963 1984 +21
Branches 128 128
============================================
+ Hits 1438 1489 +51
+ Misses 468 436 -32
- Partials 57 59 +2
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../sputnik/connector/gerrit/GerritFacadeBuilder.java | 69.69% <64.28%> (+56.65%) |
6.00 <2.00> (+4.00) |
|
...l/touk/sputnik/connector/gerrit/GerritOptions.java | 87.50% <87.50%> (ø) |
5.00 <5.00> (?) |
|
...a/pl/touk/sputnik/configuration/GeneralOption.java | 98.46% <100.00%> (+0.04%) |
3.00 <0.00> (ø) |
|
...pl/touk/sputnik/connector/gerrit/GerritFacade.java | 92.30% <100.00%> (+44.93%) |
11.00 <0.00> (+3.00) |
|
...ava/pl/touk/sputnik/connector/http/HttpHelper.java | 88.88% <0.00%> (+3.70%) |
11.00% <0.00%> (+1.00%) |
|
src/main/java/pl/touk/sputnik/review/Review.java | 67.50% <0.00%> (+5.00%) |
15.00% <0.00%> (+3.00%) |
|
.../touk/sputnik/connector/gerrit/GerritPatchset.java | 80.00% <0.00%> (+20.00%) |
4.00% <0.00%> (+1.00%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b991f9d...873547a. Read the comment docs.
Merging #222 (873547a) into master (b9482aa) will increase coverage by
2.66%
. The diff coverage is76.00%
.
@@ Coverage Diff @@
## master #222 +/- ##
============================================
+ Coverage 72.38% 75.05% +2.66%
- Complexity 608 629 +21
============================================
Files 146 147 +1
Lines 1988 1984 -4
Branches 131 128 -3
============================================
+ Hits 1439 1489 +50
+ Misses 489 436 -53
+ Partials 60 59 -1
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../sputnik/connector/gerrit/GerritFacadeBuilder.java | 69.69% <64.28%> (+56.65%) |
6.00 <2.00> (+4.00) |
|
...l/touk/sputnik/connector/gerrit/GerritOptions.java | 87.50% <87.50%> (ø) |
5.00 <5.00> (?) |
|
...a/pl/touk/sputnik/configuration/GeneralOption.java | 98.46% <100.00%> (+0.04%) |
3.00 <0.00> (ø) |
|
...pl/touk/sputnik/connector/gerrit/GerritFacade.java | 92.30% <100.00%> (+44.93%) |
11.00 <0.00> (+3.00) |
|
...l/touk/sputnik/processor/detekt/ResultBuilder.java | 78.94% <0.00%> (-2.01%) |
7.00% <0.00%> (-1.00%) |
|
...touk/sputnik/processor/ktlint/KtlintProcessor.java | 88.00% <0.00%> (-0.47%) |
9.00% <0.00%> (ø%) |
|
...k/sputnik/processor/ktlint/LintErrorConverter.java | 100.00% <0.00%> (ø) |
5.00% <0.00%> (ø%) |
|
...touk/sputnik/processor/detekt/DetektProcessor.java | 85.71% <0.00%> (+2.78%) |
10.00% <0.00%> (-3.00%) |
:arrow_up: |
...ava/pl/touk/sputnik/connector/http/HttpHelper.java | 88.88% <0.00%> (+3.70%) |
11.00% <0.00%> (+1.00%) |
|
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b9482aa...ceed77c. Read the comment docs.
I will do the merge again as gerrit lib was upgraded on master.
Recreated: https://github.com/TouK/sputnik/pull/230
Although these fixes might work on their own, they touch the same file, that's why I created one pull request for all of them.