search

TouK / sputnik

Static code review for your Gerrit patchsets. Runs Checkstyle, PMD, FindBugs, Scalastyle, CodeNarc, JSLint for you!
Apache License 2.0
201 stars 117 forks source link

Adding possibility for sputnik to load additional SpotBugs plugins like find-sec-bugs #229

Open fipciu1996 opened 3 years ago

fipciu1996 commented 3 years ago

This commit is adding the functionality of loading SpotBugs all plugins placed in the path passed to configuration.

codecov-io commented 3 years ago

Codecov Report

Merging #229 (85dd88f) into master (f6aabbc) will decrease coverage by 0.13%. The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
- Coverage     72.38%   72.25%   -0.14%     
- Complexity      608      609       +1     
============================================
  Files           146      146              
  Lines          1988     2000      +12     
  Branches        131      133       +2     
============================================
+ Hits           1439     1445       +6     
- Misses          489      493       +4     
- Partials         60       62       +2
Impacted Files Coverage Δ Complexity Δ
.../sputnik/processor/spotbugs/SpotBugsProcessor.java 75.00% <45.45%> (-6.14%) 13.00 <2.00> (+1.00) :arrow_down:
...a/pl/touk/sputnik/configuration/GeneralOption.java 98.43% <100.00%> (+0.02%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f6aabbc...3654b91. Read the comment docs.

codecov-commenter commented 3 years ago

Codecov Report

Merging #229 (ee51538) into master (3af8af7) will decrease coverage by 0.01%. The diff coverage is 73.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
- Coverage     74.98%   74.97%   -0.02%     
- Complexity      662      668       +6     
============================================
  Files           154      154              
  Lines          2099     2118      +19     
  Branches        136      138       +2     
============================================
+ Hits           1574     1588      +14     
- Misses          460      464       +4     
- Partials         65       66       +1
Impacted Files Coverage Δ
.../sputnik/processor/spotbugs/SpotBugsProcessor.java 79.76% <72.22%> (-2.06%) :arrow_down:
...a/pl/touk/sputnik/configuration/GeneralOption.java 98.57% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3af8af7...ee51538. Read the comment docs.

fipciu1996 commented 3 years ago

Any news ?

fipciu1996 commented 3 years ago

Any news ?

This commit will add a lot to SpotBugs functionality inside the sputnik. For example, findsec-bugs are adding a lot of additional security rules that aren't currently possible to verify with basic SpotBugs.

fipciu1996 commented 3 years ago

@SpOOnman could you review this change again ? 🙏

fipciu1996 commented 3 years ago

Bump

fipciu1996 commented 3 years ago

Bump

fipciu1996 commented 2 years ago

up

fipciu1996 commented 2 years ago

Up