search

TouK / sputnik

Static code review for your Gerrit patchsets. Runs Checkstyle, PMD, FindBugs, Scalastyle, CodeNarc, JSLint for you!
Apache License 2.0
201 stars 117 forks source link

Improve Gerrit connector usability #230

Closed corebonts closed 3 years ago

corebonts commented 3 years ago

Allow usage of Gerrit HTTP password tokens (#220) URL encode changeId when creating GerritPatchset (#221) Support gerrit configuration to omit duplicate comments (#108)

codecov-io commented 3 years ago

Codecov Report

Merging #230 (448173c) into master (b9482aa) will increase coverage by 1.78%. The diff coverage is 76.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
+ Coverage     72.38%   74.16%   +1.78%     
- Complexity      608      625      +17     
============================================
  Files           146      147       +1     
  Lines          1988     2009      +21     
  Branches        131      131              
============================================
+ Hits           1439     1490      +51     
+ Misses          489      457      -32     
- Partials         60       62       +2
Impacted Files Coverage Δ Complexity Δ
.../sputnik/connector/gerrit/GerritFacadeBuilder.java 69.69% <64.28%> (+56.65%) 6.00 <2.00> (+4.00)
...l/touk/sputnik/connector/gerrit/GerritOptions.java 87.50% <87.50%> (ø) 5.00 <5.00> (?)
...a/pl/touk/sputnik/configuration/GeneralOption.java 98.46% <100.00%> (+0.04%) 3.00 <0.00> (ø)
...pl/touk/sputnik/connector/gerrit/GerritFacade.java 92.30% <100.00%> (+44.93%) 11.00 <0.00> (+3.00)
...ava/pl/touk/sputnik/connector/http/HttpHelper.java 88.88% <0.00%> (+3.70%) 11.00% <0.00%> (+1.00%)
src/main/java/pl/touk/sputnik/review/Review.java 67.50% <0.00%> (+5.00%) 15.00% <0.00%> (+3.00%)
.../touk/sputnik/connector/gerrit/GerritPatchset.java 80.00% <0.00%> (+20.00%) 4.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9482aa...448173c. Read the comment docs.

corebonts commented 3 years ago

@SpOOnman Please check the changes again, I think I considered all your comments.