search

ToucanProtocol / dynamic-fee-pools

Fee calculator contracts for Toucan Protocol pools
2 stars 3 forks source link

TCO2 decimals #11

Closed kosecki123 closed 10 months ago

kosecki123 commented 12 months ago

@0xmichalis our code implicitly assumes TCO2 decimal number is 18, this is needed as we using prb-math SD59x18 type, and covert amounts into it.

Is that ok assumption or would be recommend building decimal normalisation?

0xmichalis commented 12 months ago

@kosecki123 I think this is fine. We have no plans to ever change the TCO2 decimals, that would necessitate a thorough review of our protocol. Thanks for pinging, I'll note this down in our internal docs!

aspiers commented 10 months ago

FWIW I agree with @0xmichalis here.