search

ToucanProtocol / dynamic-fee-pools

Fee calculator contracts for Toucan Protocol pools
2 stars 3 forks source link

Test fee setup with multiple recipients #20

Closed 0xmichalis closed 11 months ago

0xmichalis commented 11 months ago

Currently only a singe recipient is used in tests, need to have at least one test with multiple recipients.

PawelTroka commented 11 months ago

@0xmichalis what about these? testCalculateDepositFeesNormalCase_TwoFeeRecipientsSplitEqually testCalculateDepositFeesNormalCase_TwoFeeRecipientsSplit30To70 testCalculateDepositFees_DepositOfOne_NormalFee_FiveRecipientsEqualSplit testCalculateDepositFees_DepositOfOne_NormalFee_FiveRecipientsComplicatedSplit

kosecki123 commented 11 months ago

@PawelTroka issue was created before implementation, mark as done, add the PR which added them.

PawelTroka commented 11 months ago

ok, done in https://github.com/neutral-protocol/dynamic-fee-pools/pull/2 and more specifically https://github.com/neutral-protocol/dynamic-fee-pools/commit/68f471232c0276af24768221e4390c3a3f867c03