search

ToucanProtocol / dynamic-fee-pools

Fee calculator contracts for Toucan Protocol pools
2 stars 3 forks source link

make all fee parameters configurable #23

Closed PawelTroka closed 11 months ago

PawelTroka commented 11 months ago

fixes #15

kosecki123 commented 11 months ago

I think another good practice would be to emit the event after in the setup with all parameters listed and the current owner

PawelTroka commented 11 months ago

Wouldnt be better to have 1 function to set all params ? Also some minimal validation would be nice, so someone won't screw by mistake.

@kosecki123 I would argue that having separate functions limit the room for error validation yes, has been added

PawelTroka commented 11 months ago

I think another good practice would be to emit the event after in the setup with all parameters listed and the current owner

Ok, you mean after setting up any of the parameters or after feeSetup(..) call ?