ToucanToco / fastexcel

A Python wrapper around calamine
http://fastexcel.toucantoco.dev/
MIT License
120 stars 6 forks source link

fix: add `typing-extensions` to dependencies #227

Closed jlondonobo closed 7 months ago

jlondonobo commented 7 months ago

Purpose of This PR

This PR incorporates typing-extensions into fastexcel's dependencies, addressing Issue #226.

Outcomes

This update resolves a subtle bug in the polars library's read_excel function, specifically when utilizing the calamine engine.

Before this change, attempting to use the calamine engine would trigger an erroneous message from polars, indicating that fastexcel was not installed, despite its presence. This issue stemmed from the absence of the typing-extensions dependency.

Testing

All test are passing after running make test.