search

Toufool / AutoSplit

Easy to use image comparison based auto splitter for speedrunning on console or PC.
GNU General Public License v3.0
267 stars 30 forks source link

Feature Request: Start Minimized Options #186

Open insomnimatic opened 1 year ago

insomnimatic commented 1 year ago

I think it would probably be convenient to have an option to start the Auto-Split window minimized and / or in the hidden icon tray.

I figured this would be a nice feature to have included with the Auto-Split + LiveSplit bundle, since it would save some processing power, it would automatically help eliminate screen clutter, and basically since once you have the split screenshots and settings figured out, there's really no reason to always have the window open.

It's not a super fancy feature request, but I figured it would be worth a shot.

Avasam commented 1 year ago

Sounds reasonable :)

We're feature-freezing right now for 2.0.0. And focusing on bugfixes. But I like this feature request.

insomnimatic commented 1 year ago

I've never really done any work here on GitHub, but I could probably take the source and add a new option for "Always Start Minimized". I love me some Python, so I'll give it a shot.

Since I've never really added anything on here, I'm not sure how to update or.. I guess the right term would be to create a "fork" or "Commit". I don't want to screw anything up in that regard, so i'll post it here, if you'd like to patch it in for an update.

Thank you for taking the time to look at the request, I really do appreciate it.

Avasam commented 1 year ago

@insomnimatic Since you don't have write access to this repo (I don't even have), you can't screw anything. Worst that can happen is that your work is not accepted. As for the usual workflow, it's Create a fork -> Clone it -> Do your changes -> Stage+Commit+Push -> Create a Pull Request from the branch in your fork containing changes back to the upstream repo (usually to a branch main/master, develop, etc.) and wait for review.

As for how I see this feature work: A command line argument sounds useful for third-party integration (like livesplit). And maybe storing the option using Qt instead or the user profile (like we do for update checking)