Refactor Blinkin subsystem - Githubissues

ToughTechs151 / robot-template

Template for Tough Techs robots.

Other

1 stars 0 forks source link

Refactor Blinkin subsystem #66

Open blu28 opened 11 months ago

blu28 commented 11 months ago

In the Blinkin subsystem there is a comment that says: /*

Currently the PWM simulation code maintains separate values for the PWM when set by setSpeed,
setPosition and setSpeed. Because of this we have to be careful to always use only one pair
of get and set options so the simulator works. */

That problem was fixed with pull request https://github.com/wpilibsuite/allwpilib/pull/5277 so we could change the code to be more natural. At the very least, the comment could be removed.