search

TousstNicolas / JLC2KiCad_lib

JLC2KICAD_lib is a python script that generate a component library (schematic, footprint and 3D model ) for KiCad from the JLCPCB/easyEDA library.
MIT License
228 stars 42 forks source link

Adding a symbol to the library is sometimes added outside the structure #27

Closed Xyntexx closed 1 year ago

Xyntexx commented 1 year ago

Something in my workflow sometimes adds a new line at the end of the symbol library file. It might be git or modifying the library in KiCad. Because of the following line, the new symbol will be added outside the library structure and will not be visible in KiCad. https://github.com/TousstNicolas/JLC2KiCad_lib/blob/3920e1ff374599895b2034e14e00f5258b73f968/JLC2KiCadLib/schematic/schematic.py#L181

Xyntexx commented 1 year ago

Please test

TousstNicolas commented 1 year ago

There were a small offset issue that caused the last closing parenthesis to be taken off. I also used the footer instead of the single ")", but it is essentially the same. As always, thanks for your contribution !