search

TousstNicolas / JLC2KiCad_lib

JLC2KICAD_lib is a python script that generate a component library (schematic, footprint and 3D model ) for KiCad from the JLCPCB/easyEDA library.
MIT License
228 stars 42 forks source link

Custom footprint lib name not reflected in symbol property #40

Closed ReinBentdal closed 1 year ago

ReinBentdal commented 1 year ago

Describe the bug I am using a custom footprint library, lets call it Custom. I would expect the Footprint property of the symbol to reflect this change. For example Footprint: Custom:. But instead its still footprint:.

To Reproduce Steps to reproduce the behavior:

  1. Run script with custom footprint lib name
  2. Open downloaded symbol and see the Footprint field within its properties
  3. Its in the format footprint: instead of custom_footprint_lib:

Expected behavior I would expect it to set footprint library correctly.

Screenshots What I get:

image

Expected, with library _jlcpcb

image

Additional context This might not technically be a bug since the footprint library name is again chosen within KiCad. But it makes more sense to me to default to the name given to the library when running the script

ReinBentdal commented 1 year ago

sorry for my confusion. Mixed up schematic lib name and footprint name