TousstNicolas / JLC2KiCad_lib

JLC2KICAD_lib is a python script that generate a component library (schematic, footprint and 3D model ) for KiCad from the JLCPCB/easyEDA library.
MIT License
228 stars 42 forks source link

canonical ".pretty" directory suffix is present when referencing footprints #47

Closed vvuk closed 1 year ago

vvuk commented 1 year ago

The issue description is a little confusing. What's happening is:

So -- I typically use JLC2KiCadLib -symbol_lib lcsc -footprint_lib lcsc.pretty --skip_existing .... which puts things in a lcsc.pretty directory (good), I set up the footprint library with name lcsc.. but the symbol footprint reference looks like lcsc.pretty:foo when it should be lcsc:foo.

This is all just terrible convention, and can be fixed by just naming the symbol library "lcsc.pretty" (I think?) but I just hacked this locally to strip .pretty if it's present on the footprint library name in the symbol library.

TousstNicolas commented 1 year ago

Thanks for reporting this issue. Fixed with 61d2852