search

TousstNicolas / JLC2KiCad_lib

JLC2KICAD_lib is a python script that generate a component library (schematic, footprint and 3D model ) for KiCad from the JLCPCB/easyEDA library.
MIT License
228 stars 42 forks source link

Symbol labels missing when importing part C150858 #65

Closed markusdd closed 5 months ago

markusdd commented 6 months ago

Part C150858 (Skyworks RFX2411) in a QFN-20 package is not being generated properly.

The designations seem correct, but all the visual pin labels are missing: grafik

The EasyEDA symbol has them: grafik

I have updated to 1.0.30, same issue as in 1.0.18 which I used before.

TousstNicolas commented 6 months ago

Hi, thanks for reporting this issue.

Unless I am mistaken, KiCad does not allow hiding only one pin name, while EasyEDA allows it. In KiCad, the pin name option is defined in the symbol properties and is applied to all pins. This is the case for pin 21, which has a hidden pin name on EasyEDA.

For symbols I tested this on, most of them either had no pin name hidden or all of them. Therefore, if one of them is hidden, I apply it on all pins. As a first fix, you can manually edit the symbol property to set the "show pin name" option.

Another solution is instead of hiding all the pin names, to set the pin name to an empty string. It would have the same visual effect, but the pin name information is lost.

Let me know what you think.

markusdd commented 6 months ago

I think this probably then becomes an issue for many QFN cases because all of them have these middle GND thermal pads.

I would say it is probably not a 'fail safe default' to then hide all pins in the KiCAD output.

EDIT: Where is this option to hide pin names for a symbol? here is certainly is set to visible. I'm also confused about the unspecified direction, does EasyEDA not have those? grafik

EDITEDIT: sorry for spam, found the option, I now indeed have the pin designators visible again. I was not even aware of this option until now^^ Also really non-sensical to only have this global for all pins.

But then my initial statement stands: I think omitting pin names when just one in EasyEDA has it is probably not a fail-safe default.

markusdd commented 5 months ago

to conclude on this: would you mind changing the default or provide a switch to control this behavior? I would argue in most cases actually having the pins names is what you want unless all of them are hidden also in EasyEDA

markusdd commented 5 months ago

Thanks a lot!