search

TousstNicolas / JLC2KiCad_lib

JLC2KICAD_lib is a python script that generate a component library (schematic, footprint and 3D model ) for KiCad from the JLCPCB/easyEDA library.
MIT License
221 stars 40 forks source link

Incorrect link to datasheet in generated kicad_sym #70

Open jj-uk opened 3 months ago

jj-uk commented 3 months ago

Describe the bug In the *.kicad_sym file, property "Datasheet" is incorrect link, e.g. (property "Datasheet" "https://item.szlcsc.com/549848.html" (id 3) (at -2.286 0.127 0)

To Reproduce Steps to reproduce the behavior:

  1. LCSC part # that caused the issue C473012
  2. Arguments used for the execution JLC2KiCadLib C473012

Expected behavior Link to valid datasheet. https://datasheet.lcsc.com/lcsc/2304140030_Espressif-Systems-ESP32-WROOM-32D-N4_C473012.pdf

Screenshots

Additional context Output: ESP32-WROOM-32D.kicad_sym.TXT

markusdd commented 3 months ago

As a hint (as I rann into this at a different location for my GUI):

It is possible to correct the URL like this programatically: https://github.com/markusdd/EasyEDA_to_KiCAD_Lib_UI/commit/b6000b38bdde888cba9578ce153c9c352453df99