[Enhancement] Use the Minecraft platform ID

TouwaStar / Galaxy_Plugin_Minecraft

MIT License

16 stars 5 forks source link

[Enhancement] Use the Minecraft platform ID #1

Closed Itay080 closed 4 years ago

Itay080 commented 4 years ago

The Minecraft platform ID has been added to the API https://github.com/gogcom/galaxy-integrations-python-api/commit/8d6ec500f97e74efd709902cad2447dafc1b7397

TouwaStar commented 4 years ago

It looks like it was added to the api but the client itself doesnt handle it yet?

Its not showing up in my client after changing and i can see this in GalaxyClient.log

2019-09-06 09:30:43.983 [Warning][ (0)] [TID 16332][galaxy_client]: Failed to parse plugin manifest, exception: Unrecognized SupportedPlatform value: minecraft

Itay080 commented 4 years ago

You're right, it's not yet implemented in the client. Sorry for misleading you!

ghost commented 4 years ago

release 0.49 added minecraft definition

TouwaStar commented 4 years ago

should work correctly in https://github.com/TouwaStar/Galaxy_Plugin_Minecraft/commit/178d31bda38e9d6b490afbe0b8674864141a44c4

download plugin anew to confirm