search

TouwaStar / Galaxy_Plugin_Minecraft

MIT License
16 stars 5 forks source link

Version 0.8 breaks installation location discovery #6

Open sirrus233 opened 4 years ago

sirrus233 commented 4 years ago

It seems https://github.com/TouwaStar/Galaxy_Plugin_Minecraft/issues/4 should be re-opened. Although the plugin was previously able to locate my installed copy of Minecraft, it can no longer do so after the recent update.

Version 0.8 updates the installation discovery registry path to HKEY_LOCAL_USER\SOFTWARE\Mojang\InstalledProducts\Minecraft Launcher\InstallLocation.

On my system (64-bit, Windows 10 Pro) the original path of HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Mojang\InstalledProducts\Minecraft Launcher\InstallLocation was correct.

sirrus233 commented 4 years ago

It is worth noting that simply reverting commit https://github.com/TouwaStar/Galaxy_Plugin_Minecraft/commit/a5aa441affc85016b37d72d334969c72c36ea898 fixes the issue (for me at least - I don't know what problem this commit was originally trying to solve). Maybe it's necessary to search a few possible registry keys to find the Install location?

TouwaStar commented 4 years ago

I guess that for new installations they changed the path to the new one (because i had the previous one and after making a new installation its the local_user one now). Forgot about making it backwards compatible, i will make a quickfix to check both paths. Thanks @sirrus233