search

TouwaStar / Galaxy_Plugin_Minecraft

MIT License
17 stars 5 forks source link

Add time tracker #8

Open Pab10Suarez opened 3 years ago

Pab10Suarez commented 3 years ago

So i "added" a time tracker to minecraft thx to this https://gaming.stackexchange.com/a/306709 i just linked manually the .bat executable pretty easy but maybe this could be added to official minecraft plugin?

Maybe you normally execute the .bat but somewhere there's an option to choose the launcher

TouwaStar commented 3 years ago

To introduce time tracking like that we would have to keep the time tracked (to not loose the progress) in a local file or on a server for every plugin user

if kept in local file it would reset back to 0 on every plugin disconnect since the file would be deleted + if plugin was connected on a different pc it would send conflicting times to galaxy client.

if kept on server it would require for us to have a server to host them and to add the times together when coming in from multiple machines.

overall i dont think there isnt a very hacky solution to it but i might be wrong. If anyone comes up with a way to solve this cleanly i would consider it but the local-only approach is not worth it for me and the filehosting variant seems a big overkill (+ probably would cost something) .

urwrstkn8mare commented 3 years ago

I also implemented time tracking in my PR (#7) with the galaxyutils package which uses a local file as a backup as well as GOG Galaxy's persistent cache which has some of the same properties you've described. Thus I've actually had issues with multiple devices but there are no errors, Galaxy just overwrites the time. Luckily I only really use one device so manual local time tracking is good for that. I did submit an issue to the API repo to see if there could be fixed (here).

Pab10Suarez commented 3 years ago

I also implemented time tracking in my PR (#7) with the galaxyutils package which uses a local file as a backup as well as GOG Galaxy's persistent cache which has some of the same properties you've described. Thus I've actually had issues with multiple devices but there are no errors, Galaxy just overwrites the time. Luckily I only really use one device so manual local time tracking is good for that. I did submit an issue to the API repo to see if there could be fixed (here).

this work without using mc launcher?

urwrstkn8mare commented 3 years ago

@Pab10Suarez Sorry unfortunately you still need the launcher for now.