search

Town-of-Impostors / TownOfImpostors

TownOfImpostors Mod for Among Us
124 stars 17 forks source link

Better CrewLink: Players can hear dead after impostors die #31

Closed RuiNtD closed 3 years ago

RuiNtD commented 3 years ago

When both impostors die, BetterCrewLink thinks the game is over and allows everyone to talk. Not sure if this can be fixed in TOI but I thought I'd share it.

JonyKasual commented 3 years ago

That's probably a BetterCrewLink issue. I guess it's checking the number of live impostors to decide if the game is over? That would conflict with scenarios added by this mod where the game can continue with all dead impostors, e.g. game continues with live Arsonist.

AJMix commented 3 years ago

Hey Fayne,

Thanks for raising this issue.

As mentioned by JonyKasual, it's probably better to raise an issue in the BetterCrewLink GitHub 🙂

But I can maybe look into this specific case to see if I can potentially fix the issue on the ToI side of things

OhMyGuus commented 3 years ago

Hey,

Just got notified about this issue and removed a check which should fix this. Sadly I don't have time to test & I don't play this mod too often, so if someone wants to test it here is the build: https://ci.appveyor.com/project/OhMyGuus/bettercrewlink/builds/38610616/job/2kh63g08q4o4uc2p/artifacts

Thanks in advance!

JonyKasual commented 3 years ago

Thanks OhMyGuus.

I'll leave the issue open for a while to see if anyone else can confirm the fix. But I'm sure it'll be fine, good work.

AJMix commented 3 years ago

Thanks OhMyGuus for getting a potential fix pushed for this so quickly 😄

As mentioned by JonyKasual we'll leave this issue open and close it once we've properly tested

OhMyGuus commented 3 years ago

New version of BCL is released so this one can be closed now, sine it should be fixed 👍

If there are any other issues don't be shy to report it to me or on the BCL github

JonyKasual commented 3 years ago

Some really overdue checking. Thanks OhMyGuus! Closing this.