TownSquareXYZ / tonconnect-ui-vue

TonConnect UI Vue is a Vue UI kit for TonConnect SDK.
Apache License 2.0
21 stars 6 forks source link

Extra issue fix #10

Closed sansx closed 1 month ago

sansx commented 2 months ago
  1. optimize TonConnectUIProvider
  1. use Symble key in provide / inject
    // now we use tonConnectUIKey export from @townsquarexyz/ui-vue to inject instance in demo project, like this usage
    <script  lang="ts">
    import { TonConnectUI, useTonWallet, tonConnectUIKey } from "@townsquarexyz/ui-vue";
    const tonConnectUI = inject<TonConnectUI | null>(tonConnectUIKey, null);
    </script>

which related to #8 [Moderate] implementation 1, 2, 3, 4

sansx commented 1 month ago

Hey @dnischeta , thanks again for your suggestions and support. @cici090 just finished testing, and all the critical parts are done. Let us know if you have any further suggestions, and feel free to notify Alex that the repo is ready to merge. Also, could we connect on Telegram for smoother communication?

Thanks again!

dnischeta commented 1 month ago

feel free to notify Alex that the repo is ready to merge

Am I entitled to do it? I mean, he asked me to do a general review. We can clear everything up in Telegram.

Also, could we connect on Telegram for smoother communication?

Feel free to contact on Telegram: https://t.me/dimchickLoveNY .

sansx commented 1 month ago

Yeah, since Alex asked you to handle the general review, we’d like to let you inform him to keep the process smooth and complete, and then we can push this into next step. And it's not the must, we can let him know this in some other day. :D