search

Townk / vim-autoclose

This plugin for Vim enable an auto-close chars feature for you. For instance if you type an '(', ``autoclose`` will automatically insert a ')' and put the cursor between than.
http://townk.github.com/vim-autoclose/
503 stars 66 forks source link

Easy config and code refactoring #16

Closed artm closed 12 years ago

artm commented 12 years ago

Some weeks ago I decided to put some effort into the plugin and read the code multiple times to figure out what was going on. As I did that I wrote comments, renamed functions and variables and simplified the code where ever I saw how. I believe the result is much more newcomer friendly and as I'm committed to continuing the development I would like my changes to enter the official repository.

This pull request contains some of my refactorings, some documentation changes and several new configuration features targeted to the users of the plugin.

In my master are some new features on top of this, but I don't want to rebase them onto current official master, so I won't request to pull them yet.

Townk commented 12 years ago

Hi Artem, first of all thank you!

For long I wanted to continue this but a lot of changes happening in my life and this was left behind. As you could see since yesterday I approved your pull requests and I intent to see if there is anything else I would like to add this weekend and than send an "official" version to vim site.

One of the things I'm planning is to auto-expand the char after a {. I already did it once but the result was not good enough and I removed.

Anyway, once again thanks for the effort put on this!

artm commented 12 years ago

I have optional CR expansion inside {} in my master. I also have optional space expansion inside all pairs.

these two are in individual commits but a bit experimental so far.

On Tue, Nov 8, 2011 at 15:13, Thiago Alves < reply@reply.github.com>wrote:

Hi Artem, first of all thank you!

For long I wanted to continue this but a lot of changes happening in my life and this was left behind. As you could see since yesterday I approved your pull requests and I intent to see if there is anything else I would like to add this weekend and than send an "official" version to vim site.

One of the things I'm planning is to auto-expand the char after a {. I already did it once but the result was not good enough and I removed.

Anyway, once again thanks for the effort put on this!

Reply to this email directly or view it on GitHub: https://github.com/Townk/vim-autoclose/pull/16#issuecomment-2667823

Artm Baguinski, Software Engineer, V2_ Institute for the Unstable Media, http://www.v2.nl/

tel: +31.6.29394010 skype: v2_artm web: http://claimid.com/artm/