search

TownyAdvanced / MapTowny

A Towny add-on Bukkit plugin that enables towns to show up on a web-map.
MIT License
19 stars 18 forks source link

Show custom townranks and area of the map controlled by each town inside the hoverinfo for towns #12

Open leomeinel opened 2 years ago

leomeinel commented 2 years ago

Additional context Would be nice, so its more coherent with the server setups and the area controlled by town (of total map size) would also be very useful for competition!

silverwolfg11 commented 2 years ago

You can already display custom town ranks within the hover info. Simply use the placeholder %rank_%. For example if there was a "co-mayor" town rank, the placeholder would be %rank_co-mayor%.

As for the area controlled by town, I am not sure it's really feasible to get the "map size". For worlds without any borders, the map size is, for all intensive purposes, infinite so the proportion of area controlled by a town will be effectively zero. I guess I could use the area of vanilla world border as a map size, but I also know many servers use separate world border plugins to implement world borders, so I am not sure how applicable this feature would really be to many servers.

silverwolfg11 commented 2 years ago

After you posted this, I wanted to confirm that custom town ranks did work and I realized there was a bug in displaying them. I have created a separate bug ticket and it will be fixed in the 1.0.0 release.

Thank you for making me aware of the bug!

leomeinel commented 2 years ago

Okay perfect! Thanks silverwolfg11. About the map size, I already thought about that too. You could make either a config option to enter the radius/diameter of the map or get the vanilla world border by default. I can only assume but it'd apply to a lot of people in my opinion. For those that don't use a worldborder you could also just disable the option by default and set a config option that you have to set true for the function to be enabled at all. It's more of a nice to have, if you think that its worth it that would be a way to make it fit every server I think.