search

TownyAdvanced / MapTowny

A Towny add-on Bukkit plugin that enables towns to show up on a web-map.
MIT License
22 stars 18 forks source link

Adding Pl3xMap v3 Support #45

Closed Agaloth closed 1 year ago

Agaloth commented 1 year ago

Haven't tested it in-game yet, just focused on fixing all errors between v2 and v3 and this doesn't have any other errors.

Agaloth commented 1 year ago

Just pushed a new pull request, I compiled the plugin and tested it on my local server, and everything works perfectly.

image image image image

Agaloth commented 1 year ago

The .iml files should be removed from this PR as they're in the gitignore, the changes to the jitpack_toolchain.xml file can also be undone.

Thanks, done!

Agaloth commented 1 year ago

Thanks @Warriorrrr for helping.

The latest commit makes it so that the plugin works on v2 (tested it) and it should also keep v1 support.

shpellar commented 1 year ago

bro accept this pull already

PainOchoco commented 1 year ago

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Agaloth commented 1 year ago

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao

shpellar commented 1 year ago

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao

false information kkthx

Agaloth commented 1 year ago

bro accept this pull already

if you're really in a hurry, you can follow the instructions on the readme to build the plugin yourself.

Dude even asked for a jar and I gave it to him since he couldn't build it then he started suspecting me of adding a malware to it lmfao

false information kkthx

image image image

Please stop creating unnecessary drama

silverwolfg11 commented 1 year ago

Thank you so much for adding support for the new version of Pl3xMap!

I know there was some discussion about removing v1 support. However, Pl3xMap v1 is technically the only stable release of Pl3xMap. Both v2 and v3 don't have a stable release. Hence, until v3 (hopefully) has a stable release, compatibility for all v1,v2, and v3 will be kept.

P.S. Sorry for taking so long to review and merge it, but thank you for your patience.

PainOchoco commented 1 year ago

You can also update the readme ;)