search

TownyAdvanced / MapTowny

A Towny add-on Bukkit plugin that enables towns to show up on a web-map.
MIT License
22 stars 18 forks source link

Console on disable during server shutdown #46

Closed Momshroom closed 1 year ago

Momshroom commented 1 year ago

Describe the Bug

Console error on plugin disable during server shutdown. https://paste.gg/p/Momshroom/07f69e2e6ad64e459e1ebc4ac609eeab

Expected Behavior

No errors :3

Plugin Version

2.1.1

Towny Version

0.99.2.0

Pl3xMap Version

1.20-441

Server Software Version

Paper 1.20.1 build 43

Additional Comments

Thanks for the cool plugin!

silverwolfg11 commented 1 year ago

Hi,

Thanks for using the plugin! Just to make sure, are you using MapTowny 2.2.0? Only MapTowny v2.2.0 supports Pl3xMap v3.

Momshroom commented 1 year ago

On Fri, Jun 23, 2023 at 11:37 PM silverwolfg11 @.***> wrote:

Hi,

Thanks for using the plugin! Just to make sure, are you using MapTowny 2.2.0? Only MapTowny v2.2.0 supports Pl3xMap v3.

— Reply to this email directly, view it on GitHub https://github.com/TownyAdvanced/MapTowny/issues/46#issuecomment-1605263166, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEATM2D4UBSDBRVFH2EXMILXMZVKJANCNFSM6AAAAAAZSH6BOA . You are receiving this because you authored the thread.Message ID: @.***>

I’m using 2.2.1. Llmdl compiled it for smallsansserif on the towny discord and I also downloaded it.

Momshroom commented 1 year ago

Clarifying that I'm using it compiled from the latest commits. There wasn't a released binary with the Pl3xMap 3 support

silverwolfg11 commented 1 year ago

Hi,

I looked into the issue, but unfortunately I'm not able to reproduce it. The code-related portion of the error also looks correct, so I'm not even sure how the error could occur in the first place.

I think the next steps would be trying to find some sort of pattern that would lead to reproducing the issue. Does the issue occur on every shutdown so far?

I also noticed that there are new Pl3xMap updates available, so maybe that could potentially fix the issue? I'm not sure if you want to give that a try.

For context, I'm running / testing on the environment:

I don't think the differences in environments would cause the issue since MapTowny is compiled against Pl3xMap-1.20.1-446.

Momshroom commented 1 year ago

This seems to be fixed with the release map towny 2.2.0 and pl3xMap updates. I'm not sure which fixed it, but thank you for looking into it.