Siegewar thinks a siege is still happening even after it ended?

[blockutis]

Describe the bug A siege was going on with a town, and then the attacker placed a white banner to surrender. After all 7 battle sessions had passed, in chat it said that the attacker had successfully abandoned it and that the town was saved. The town's name no longer appears as a tab-complete option with the command /sw hud, however, if you still input the towns name yourself, using /sw hud TownName, it shows the hud for the siege, with the Siege Status being "Attacker Abandon", as shown here:

Also, when attempting to break the banner that was used to start the siege, it acts as if the banner is being used for a siege assembly:

To Reproduce

1. Start a siege on a town.
2. Wait 24h to be able to surrender the siege.
3. Place the white banner to surrender.
4. Wait until all 7 battle sessions have passed and the siege "ends"
5. In chat it will say that the attacker has abandoned it and the town is saved.
6. Try to break the banner, it doesn't let you, and says there is a siege assembly in progress.
7. Try doing /sw hud TownName, and observe that the command still works, instead of saying "Town TownName does not have any active sieges" like it should.

Expected behavior The siege should have ended, the banner should be breakable and the /sw hud command for that town should return "Town TownName does not have any active sieges".

Screenshots /town Terra output: Hovering over [Sieged]:

Versions (please complete the following information):

• Towny: Version 0.99.1.0
• SiegeWar: Version 2.5.1
• Spigot/Paper: git-Paper-307 (MC: 1.19.2)

Files Startup log: https://mclo.gs/AdKF2YB SiegeWar config: https://pastebin.com/ZwcGfarA Townyperms.yml: https://pastebin.com/WrfpFbvR

[Goosius1]

Hi there's 3 issues here

Issue 1:

• The siege is not deleted after the progress is 7/7 complete
• This is the way sieges have always worked. The siege has ended. Just instead of being completely deleted, it has entered the "siege aftermath" phase. This phase is needed for people to see a record of who won, and more importantly to allow people to place the capture/plunger flags.

Issue 2:

• You can force the hud to show the ended siege
• Most player's would know the siege is over and wouldn't be trying to do this. And some players might occasionally want to get the hud to show this information. Thus is seems worthwhile to keep supporting.

Issue 3:

• Can't break banner after siege is ended
• This definitely sounds like a bug, and needs further investigation

[blockutis]

Yeah sorry I should have thought of that. I guess I thought since it was Attacker Abandon, that it would immediately end. Idk.

Anyway, how long is it meant to stay? Currently the siege still shows up in /sw hud and the banner still cannot be broken. Haven't looked to see exactly how many battle sessions, but it's been at least 2 battle sessions since then, the siege ended over 43 hours ago. And the same error message, claiming there's a siege assembly, still shows up when trying to break the banner.

[Goosius1]

• The siege aftermath is meant to stay the siege immunity is over. So 6.9 days.
• The reason Sieges stay active for the normal duration even after an attacker abandon, is a good one -> It is to prevent fake sieges where a nation would try to protect a friendly town by sieging then, and them immediately lifting the siege when tthe danger is passed.
• The banner breaking thing sounds like a bug. But I haven't looked at it yet. As a workaround for now, you could try disabling Siege Assemblies, and see if that has any effect on the banner breaking issue.