TownyAdvanced / SiegeWar

A war plugin for Towny.
https://townyadvanced.github.io/
Other
59 stars 38 forks source link

max_active_siege_attacks_per_nation can be bypassed when SiegeAssemblies are used. #886

Closed LlmDl closed 1 year ago

LlmDl commented 1 year ago

Describe the bug

max_active_siege_attacks_per_nation Is only checked when a Siege/SiegeAssembly is started, and it only counts active Conquest sieges.

A nation can pack in multiple Siege Assemblies, which will all result in Sieges.

To Reproduce Steps to reproduce the behavior: Set a max_active_siege_attacks_per_nation of 2, then go make 3 Siege Assemblies.

Expected behavior At the end of a successful Siege Assembly, it should re-check if the nation has too many sieges, so that the limit is respected.

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

Files Startup log: n/a SiegeWar config: n/a Townyperms.yml: n/a