Banners after sieges will now display a permanent record of the siege in their lore and name.
Right clicking the placed lore banner will give a chat message with data, this allows players to display banners (e.g in a museum) and allow other players to come through and view the details without needing to hold the physical item.
Right clicking air with the banner item will display the same message.
The banner can be crafted into a Siege Shield with the lore and name intact - The lore and name are also kept intact when placing and breaking it.
The lore banners can not be used to start a new siege, they must craft a new banner.
This should allow players to trade banners from well-known sieges or create museums.
New Nodes/Commands/ConfigOptions:
siege_lore.enabled
Enables or disables the Siege Lore feature, currently no further configuration than this.
Adds a lot of translation keys for Siege Lore to make the text as configurable as possible.
Relevant Issue ticket:
854
[x] I have tested this pull request for defects on a server.
I have tested this pretty thoroughly on 1.20.4 and not been able to cause any issues, it correctly blocks/allows sieges, breaking, placing, crafting the banner worked in all circumstances. Intentionally messing up Siege data by removing it before ending it with admin commands is handled.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.
Description:
Banners after sieges will now display a permanent record of the siege in their lore and name.
Right clicking the placed lore banner will give a chat message with data, this allows players to display banners (e.g in a museum) and allow other players to come through and view the details without needing to hold the physical item.
Right clicking air with the banner item will display the same message.
The banner can be crafted into a Siege Shield with the lore and name intact - The lore and name are also kept intact when placing and breaking it.
The lore banners can not be used to start a new siege, they must craft a new banner.
This should allow players to trade banners from well-known sieges or create museums.
New Nodes/Commands/ConfigOptions:
siege_lore.enabledAdds a lot of translation keys for Siege Lore to make the text as configurable as possible.
Relevant Issue ticket:
854
I have tested this pretty thoroughly on 1.20.4 and not been able to cause any issues, it correctly blocks/allows sieges, breaking, placing, crafting the banner worked in all circumstances. Intentionally messing up Siege data by removing it before ending it with admin commands is handled.
By making this pull request, I represent that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the TownyAdvanced organization has the copyright to use and modify my contribution under the SiegeWar License for perpetuity.