search

TownyAdvanced / SiegeWar

A war plugin for Towny.
https://townyadvanced.github.io/
Other
59 stars 39 forks source link

failed_siege_assembly_cooldown Setting Not Working #939

Open pelicano0 opened 1 month ago

pelicano0 commented 1 month ago

Describe the bug When I set the failed_siege_assembly_cooldown to 12 hours, I can attempt to declare war on the same town again before the 12 hours have passed if the war is canceled.

Expected behavior Not being able to declare war again before 12 hours have passed.

Versions (please complete the following information):

LlmDl commented 1 month ago

It would be good to have your siegewar config.

pelicano0 commented 3 weeks ago

I can reproduce this error even with the default configuration.

LlmDl commented 3 weeks ago

Ok, what did you mean by "if the war is canceled."

I need clearer instructions on how to reproduce your results.

pelicano0 commented 3 weeks ago

In the SiegeWar configuration, if the assemblies_enabled setting is enabled and the failed_siege_assembly_cooldown is set to, for example, 12 hours, you can start a siege assembly by placing a banner in any town, and if it fails, you are still able to start another siege assembly by placing another banner in the same town. However, the intended behavior is that you should not be able to start another siege in the same town within 12 hours (or the specified cooldown time) until that period has passed.

LlmDl commented 3 weeks ago

In what manner is your siege assembly failing?