TownyChat + EssentialsChat

[LlmDl]

Originally reported on Google Code with ID 1756

What steps will reproduce the problem?
1. Set up EssentialsChat with grouping/ranks
2. Install TownyChat - Take out Global Channel from config
3. TownyChat begins to error but works as intended, spamming the console:
http://pastie.org/private/aezkzp4mjjblyoyxkejkg

What is the expected output? :
No Errors

What do you see instead? :
Errors

What is your Towny version number? :
0.83.0.1

What is your TownyChat version number? :
0.39

What is your Bukkit version number? :
Spigot 

What operating system? :
CentOS

Please use pastebin.com to link the following files:
Startup Log:
2013-06-17 22:36:19 [INFO] [TownyChat] -******* TownyChat enabled *******-
All you need to know, both start up correctly with no errors

- Your towny config.yml,

http://pastebin.com/HuuNtTSy

- Your townyperms.yml,

N/A

- Your permissions file.

N/A

In the case of chat-issues please link your:
- Chatconfig.yml

http://pastebin.com/L35vJJN1

- Channels.yml

http://pastebin.com/XRyW8aCw

From experience and from the people I have spoken to that join the IRC Channel, suggestions
are often brushed aside and getting anything changed is like pulling teeth, so please
take this into consideration, its very simple:

Allow disabling of TownyChat overriding the global chat, either through config or by
default, so we can use our own plugins for handling chat, and keep the Town Chat available
for players with /tc. I personally use EssentialsChat and I don't want to "modify false"
because I like it's handling of global chat while keeping tc. If i try tc with modify
false it goes to global.

Reported by mobilephone2003 on 2013-06-17 22:09:33

[LlmDl]

2 ways to go about this:

1. Do not use EssentialsChat, everything that it does townychat can do and more

2. Do not give anyone the towny.chat.general node, this will mean no ones sees or speaks
on that channel.

Reported by LlmDlio on 2013-06-18 01:54:08

• Status changed: Need_Feedback

[LlmDl]

1. Not a solution at all, unless TownyChat has the ability to give its own prefixes
for each group without using permissions prefixes. Using permissions prefixes messes
up other things in essentials like private messaging, online lists, and permanently
attaches that prefix to any plugin that requires the username.
2. They don't have it anyway, and this has been tried countless times on  a test server
with _no_ permissions:
http://gyazo.com/50db8bc05822692a8947d366405df715

Reported by mobilephone2003 on 2013-06-18 05:39:29

[LlmDl]

pastebin.com the townyperms.yml

Reported by LlmDlio on 2013-06-18 05:42:04

[LlmDl]

http://pastebin.com/fabCV5dT

Reported by mobilephone2003 on 2013-06-18 05:44:13

[LlmDl]

Remove the towny.chat.general from the nomad group in there.

Reported by LlmDlio on 2013-06-18 06:02:51

[LlmDl]

http://gyazo.com/73075345cea2d0ffd4019c5327f62353

Still overrides it, that user should have the [Owner] tag

Reported by mobilephone2003 on 2013-06-18 06:11:09

[LlmDl]

http://gyazo.com/73075345cea2d0ffd4019c5327f62353

Still overrides it, that user should have the [Owner] prefix

Reported by mobilephone2003 on 2013-06-18 06:11:29

[LlmDl]

Can you show me a current full startup and your permission plugin's file.

It would also be nice to see your chatconfig.yml if you've changed it since the one
you posted above.

Reported by LlmDlio on 2013-06-18 12:40:57

[LlmDl]

Can't show you the permissions file because I'm using MySQL to sync them across all
my servers in the network. If there's a perm you'd like me to check I can check it.

The screenshot I showed was on my local server with an old cluttered Pex file, Towny
and EssentialsChat. No other plugins. The same config is used on the live server.

Full startup on Standard Server:
http://pastie.org/private/2ohykb8iwkmok2z8va34yq

Chatconfig.yml (used on both):
http://pastie.org/private/d1izhometfpfosiezidc7a

Reported by mobilephone2003 on 2013-06-18 12:48:35

[LlmDl]

Scratch that, the local server didn't have pex

Reported by mobilephone2003 on 2013-06-18 12:49:58

[LlmDl]

Show me the startup of the test server and a new screenshot.

Reported by LlmDlio on 2013-06-18 12:53:07

[LlmDl]

It's probably better if you see this to understand it.

I'll go one better. Here is a very simple local server (only 23MB) ready to go on localhost
with EssentialsChat and TownyChat, with chat modify set to false. Just run spigot.bat
(or make a start.sh if you're on linux to run the spigot.jar)

https://www.dropbox.com/s/ewof4pyjocw8erd/TownyandEssentials.zip

You'll see that even when you try to switch to town chat, the message will go to global.

If you turn modify_chat to true, you'll see the error that is constantly flooding my
live server right now.

The ranks that should be showing start at line 440 in /plugins/Essentials/config.yml
(default is [Member])

Reported by mobilephone2003 on 2013-06-18 13:08:39

[LlmDl]

I don't have the time to do that now, show me the full startup of your test server and
the corresponding screenshot of the chat, showing all the channels.

Reported by LlmDlio on 2013-06-18 13:22:20

[LlmDl]

... I don't have the time to be messing with something that should be working either
but I am. You shouldn't offer support if you "don't have the time" to help people,
I'm putting in the time to show you the issue. 

This issue has prevented me upgrading to the latest towny, and I've been using TownyChat
0.31 or earlier just to skip the issue, but that doesn't work anymore.

Here, lots of screenshots and configs:

** Startup Log (same for all of the following screenshots, no errors) **
http://pastie.org/private/m2o6brjeenpposmiox7c9w

Chat with Modify_chat false, speaking in tc, no global channel:
Screenshot: http://gyazo.com/35700ec5c49ff4ca0e89b912b66d3772
Config with Modify_chat false: http://pastie.org/private/kcwvywcbsxzw8foxaspa

Chat error in action with Modify_chat true, no global channel, speaking in global:
Screenshot: http://gyazo.com/de254eb6f0a739a0076b23a8cde6e4f1
Config with Modify_chat true: http://pastie.org/private/aghhrtknp8emzabhpuri7q

Chat with a _new chatconfig.yml_ with modify true (bypasses EssentialsChat):
Screenshot: http://gyazo.com/29498c0f465a5442d26d486cf94b7827

Chat with a _new chatconfig.yml_ with modify false:
Screenshot: http://gyazo.com/fb93ab692877e96fbddb2f10cf9b9f54

The best option currently for the live server is with global channel + error. It works
as intended, can TownyChat please have an option to disable global chat. PLEASE.

Reported by mobilephone2003 on 2013-06-18 13:45:11

[LlmDl]

The last screenshot is probably the most significant. You'll see with default values
and modify false, messages directed for towns are not directed to towns.

Reported by mobilephone2003 on 2013-06-18 13:50:11

[LlmDl]

Towny cannot find your {permprefix} because you do not have a permission plugin on your
test server. Put in your pex and test it. Also, do not cut out the global channel_format,
it should be there but towny will not use it if no one has the permission node for
it.

Reported by LlmDlio on 2013-06-18 13:54:12

[LlmDl]

I've already said that I don't want to use pex prefixes, the groups are set in EssentialsChat,
pex only has the colour.

Either way:

Pex on, Modify_chat false: http://gyazo.com/1285d4de98f8af7e920275e529b5746c

Pex on, Modify_chat true: http://gyazo.com/8c0947b3ba0cc1e13c30fe9b7c005700

Same issue. TownyChat should be forwarding onPlayerChat to TC, and not showing to global,
but it isn't. If Modify_chat means don't modify the chat including tc, theres no point
in having the plugin at all.

Here's why I don't want to use pex prefixing, i added my member tag to pex:
http://gyazo.com/8020a12bf8c45311ccb4ad8efe958d0f - Imagine this with 70+ players
http://gyazo.com/5733f021b76cea37031d0f01016daca0 - Unnecessary prefix in /msg

Pretty much everything in essentials calls on these usernames with prefixes, other
plugins do it too, all I need is the coloured name, not the prefix.

All i want is this without the error:
http://gyazo.com/35700ec5c49ff4ca0e89b912b66d3772

It works perfectly that way, and disregards the channel it shouldn't be controlling.

Reported by mobilephone2003 on 2013-06-18 14:16:42

[LlmDl]

Sorry, this without the error: * http://gyazo.com/de254eb6f0a739a0076b23a8cde6e4f1

Reported by mobilephone2003 on 2013-06-18 14:18:12

[LlmDl]

Re: modify_chat setting, this is a relic, something that shouldn't be changed from true,
so leave it true.

In the channel_format section:

- Add the global line but dont give the permission node for it. 

- Remove {permprefix} from all the format lines if you arent going to be using it.

The error is probably cause you've removed the global section.

Reported by LlmDlio on 2013-06-18 22:31:54

[LlmDl]

This still means I have to use TownyChat by default, which affects the rank format i've
been using for a year and a half, rank formats people have donated for

Reported by mobilephone2003 on 2013-06-18 22:34:34

[LlmDl]

Screenshot of this, with pex back to the colours, now nobody has a prefix, just {modplayername}:
http://gyazo.com/9101de13d9d5c02da7c07ba1aa8c10a8

Reported by mobilephone2003 on 2013-06-18 22:41:25

[LlmDl]

If you're around join the IRC: http://webchat.esper.net/?channels=towny

I'm off work and am on there, it will be waaay easier to troubleshoot this.

Reported by LlmDlio on 2013-06-18 22:51:42

[LlmDl]

This is confirmed via testing and is being fixed.

Reported by LlmDlio on 2013-06-24 17:30:01

• Status changed: Started

[LlmDl]

Fixed and part of TownyChat 0.40 and TownyAdvanced 0.84.0.0

Reported by LlmDlio on 2013-06-24 18:13:31

• Status changed: Fixed