TownyAdvanced / Towny

Towny Advanced Minecraft plugin for Bukkit/Spigot.
https://townyadvanced.github.io
Other
526 stars 352 forks source link

TownyChat commands not working and minimessage not parsing #6867

Closed o7-hmoe closed 1 year ago

o7-hmoe commented 1 year ago

What steps will reproduce the problem?

ISSUE 1: colors not parsing in /channel

  1. install townyChat 0.107 and Towny 0.99.5.0
  2. execute /channel
  3. notice that the colour codes are displayed as instead of the colour.

ISSUE 2: colors not appearing in {msgcolour}

  1. install townyChat 0.107 and Towny 0.99.5.0
  2. Open Channels.yml and change the messagecolour of town chat to be &e
  3. Open ChatConfig.yml and change channel_format for town entry to be: '{channelTag} {towntag}{townyprefix}{modplayername} : {msgcolour}{msg}'
  4. restart server or try using /townychat reload, if it works
  5. notice that the {msgcolour} which should be applying yellow, does not apply yellow to the chat message

What is the expected output?

Output listed above in each issue

Towny version

Towny 0.99.5.0 TownyChat 0.107

Server version

Paper version git-Paper-72 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: a3c760e)

Please use Pastebin.com to link the following files

  1. Your full server startup from the logs\latest.log: https://pastebin.com/E2Ba8Rhf
  2. Your Towny config.yml: https://pastebin.com/mAEbF9RB
  3. Your townyperms.yml: https://pastebin.com/vb0mLcZ1
  4. Your log's error: none

(optional) If this is to do with permissions,

  1. Your permissions file:

(optional) If this is to do with chat,

  1. Your chatconfig.yml: https://pastebin.com/1wF35Zmh
  2. Your channels.yml: https://pastebin.com/kv48sGyA
o7-hmoe commented 1 year ago

removed issue of /townychat reload not working, it works as intended

LlmDl commented 1 year ago

The channels.yml link has expired.

LlmDl commented 1 year ago

I also wonder if MessageFilter, ChatControl might be to blame.

Because we were able to see get parsed we know that the channels' msgcolour isn't null, when a msgcolour is null we just replace {msgcolour} with "". That leads me to believe that the colour code was added, but was being removed.

Does either of the above plugins require a permission node to colour player chat text?

o7-hmoe commented 1 year ago

I'll test it on a local test server running just towny and townychat and see what happens.

Not sure about permission nodes but I was typing in chat as an operator so I shouldnt need any permissions. I think this might be an issue on my end.

On Thu, Jul 20, 2023 at 7:54 AM LlmDl @.***> wrote:

I also wonder if MessageFilter, ChatControl might be to blame.

Because we were able to see get parsed we know that the channels' msgcolour isn't null, when a msgcolour is null we just replace {msgcolour} with "". That leads me to believe that the colour code was added, but was being removed.

Does either of the above plugins require a permission node to colour player chat text?

— Reply to this email directly, view it on GitHub https://github.com/TownyAdvanced/Towny/issues/6867#issuecomment-1644074761, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFCQHCJ37YKBMNCA6ZOAP63XRFBDDANCNFSM6AAAAAA2QWFM24 . You are receiving this because you authored the thread.Message ID: @.***>

LlmDl commented 1 year ago

I've got a PR for fixing the helpmenus that's already been merged, the code for message colouring looks good though.

LlmDl commented 1 year ago

Capture Just switched the town chat from default to &4 and successfully got it to work.