search

TownyAdvanced / TownyFlight

Flight plugin for Towny servers.
https://townyadvanced.github.io/
Other
22 stars 17 forks source link

(v1.5.5) `config.yml` uses strings for booleans #24

Closed MilesBHuff closed 4 years ago

MilesBHuff commented 4 years ago

The boolean fields in the options section of config.yml are quoted. They should be unquoted so that they can be read directly as booleans, since strings are comparatively expensive.

MilesBHuff commented 4 years ago

This one is really easy for me to just fix and PR, but I don't like making PRs without testing first, and the time it would take to get my environment set-up for this project isn't worth the silliness of this "bug". What I can say, though, is that the config file works when I remove the quotes, so it should be very safe to make this change. Even if Java ends-up parsing them as strings, anyway, at least we've saved a couple characters in the config file.

LlmDl commented 4 years ago

yeah I dont care enough about whether it's true or 'true' either.

MilesBHuff commented 4 years ago

Haha, no worries. Worth mentioning, was all.