TownyAdvanced / TownyProvinces

An add-on plugin for Towny, which makes claiming more organized, reducing staff workload and server toxicity.
20 stars 10 forks source link

Include coin.png as a plugin resource #108

Closed lexiccn closed 7 months ago

lexiccn commented 7 months ago

Does not have an associated issue

The original icon has rules against hotlinking, which this plugin technically does not do as the icon is only downloaded on reload of the plugin - However it's clearly against the spirit of the rules and does download excessively, so I've changed this to an included resource coin.png to avoid this issue. Similarly, this is why I decided resetting the config option was the best solution.

On the upside this allows users to include custom files, not just URLs, and adds a fallback if it is invalid rather than failing to display.