Webmap integration reloading fixes

TownyAdvanced / TownyProvinces

An add-on plugin for Towny, which makes claiming more organized, reducing staff workload and server toxicity.

20 stars 10 forks source link

Webmap integration reloading fixes #97

Closed lexiccn closed 1 year ago

lexiccn commented 1 year ago

Fixes:

Reloading BlueMap or Pl3xMap with their command
Changing Map Refresh period when reloading with /tpra
Changing Town Costs icon when reloading with /tpra
Changing whether Dynmap uses this icon when reloading
Modifying Pl3xMap layer attributes

Changes:

Throws RuntimeException when invalid Town Costs icon (Even if it is not used in Dynmap for simplicity/parity)
Remove equality checks before setting Marker colour in Pl3xMap v3 and Dynmap
Catch RuntimeException on a per-map basis in TownyProvinces, do not catch any other Exception

lexiccn commented 1 year ago

When merging with the other BlueMap branch for the intended result, there is one conflict that is easy to resolve, specifically: BlueMap constructor should contain this onEnable function:

BlueMapAPI.onEnable(e -> { addProvinceBordersMarkerSet(); addProvinceHomeBlocksMarkerSet(); reloadAction(); });

Automatic merge tools such as in IntelliJ will try to put the markerSet adders into reloadAction, this is not correct and will not work.