search

Tox / tox.chat

The Tox Project's official website
https://tox.chat
Creative Commons Attribution Share Alike 4.0 International
231 stars 52 forks source link

Why isn't TRIfA mentioned in the client list? #235

Closed thomas725 closed 3 years ago

thomas725 commented 3 years ago

TRIfA seems to me to be by far the most stable and feature rich Android Tox client, though on https://tox.chat/clients.html only aTox is mentioned, why is that?

Would you accept a pull request to https://github.com/Tox/tox.chat/blob/master/themes/website/templates/clients.html to remedy that mistake?

nurupo commented 3 years ago

TRIfA uses a weird-looking fork of Toxcore which, as far as I know, no core developers have reviewed or looked at at all. GitHub says that it's 903 commits ahead of TokTok/c-toxcore. It's developed by TRIfA's developer alone while core developers continue working on TokTok/c-toxcore (even if it's not very active right now). As such, it's not something we are comfortable recommending users to use.

thomas725 commented 3 years ago

It still seems mostly compatible with all the other Tox-Clients I tried...

Could you specify what's "weird-looking" about it? Sorry, I'm not really too fluent in the C / C++ language...

Isn't Tox about the specification instead of one specific library implementation of it? Seems a bit arbitrary that all client's need to use the same specific implementation of the Tox protocol?

You could maybe put a warning sign next to it saying you cannot judge if and how safe it still is with its toxcore modifications - instead of leaving it out all together?

nurupo commented 3 years ago

Again, the issue is that it uses a fork of Toxcore that haven't been reviewed by any core developer, or anyone else for that matter. As such, it's not something we are comfortable recommending users to use.

Also, to quote the README:

When submitting a request for client addition [to the website], keep in mind that we expect the clients we list to be of high quality. It's not our intention [for the website] to list every single Tox client in existence. Rather, the intention is to provide a curated list of Tox clients.

If you don't think that your client is ready to be listed on the website but still want to list it somewhere, you could add it to the list of clients on the wiki and the TokTok website(repo).

The tox.chat website features a curated list of clients, while the wiki and the TokTok websites are mostly unrestricted. To note, TRIfA is, in fact, listed on both of the wiki and the TokTok website.