Toxantron / scrumonline

PHP web app for planning poker
https://www.scrumpoker.online
Apache License 2.0
399 stars 286 forks source link

Display private repos #27

Closed Daiben closed 7 years ago

Daiben commented 7 years ago

Is it possible to watch the issues from private repo's?

Toxantron commented 7 years ago

@Daiben not yet, but I could extend the Github Plugin to include Github OAuth authorization.

It might take a while to read into it and implement it. Just from a quick browse it should be possible, but a question remains: To access private repos or at least their issues, users will have to grant "me" permission to do so. Since I do not have a user model and do not plan on implementing it, as long as I can not guarantuee the safety of that data. Therefor users either would have to go through the process over and over OR I could display the token so they can store it somewhere to use in the next session.

What would you prefer?

Daiben commented 7 years ago

@Toxantron I can help you maybe

https://developer.github.com/v3/#basic-authentication

Basic authentication is fine for me.

https://developer.github.com/v3/auth/

Beforesend: http://api.jquery.com/jQuery.ajax/

beforeSend: function (xhr) { xhr.setRequestHeader ("Authorization", "Basic " + btoa(username + ":" + password)); },

Toxantron commented 7 years ago

Thanks for the links. The first one I use already and the second I saw when looking up the API.

I wasn't sure if users are comfortable entering their Github password and OAuth is the preferred way. Never the less let's start with Basic and we can add OAuth later.

Daiben commented 7 years ago

Great 👍 I dont mind basic authentication.

Toxantron commented 7 years ago

Done. Could you take it for a spin, @Daiben and give me feedback?

Toxantron commented 7 years ago

Make sure to clear your cache of scrumpoker.online first.

Daiben commented 7 years ago

Great :) thanks 👍

Toxantron commented 7 years ago

You are welcome. :-) Closed?

Daiben commented 7 years ago

Review #28 please aftewards you can close it :)

Toxantron commented 7 years ago

Merged and made "pretty". ;-)