Toxantron / scrumonline

PHP web app for planning poker
https://www.scrumpoker.online
Apache License 2.0
400 stars 288 forks source link

Improve project structure #60

Open faniereynders opened 7 years ago

faniereynders commented 7 years ago

To accommodate future projects like mobile apps and other experiments we need a better structure for supporting these artifacts. As suggestion is that we can make use of Github's Organizations to host these projects.

The proposed initial structure overview:

Toxantron commented 7 years ago

An organization with multiple repos makes sense. So far it was only the small web-project and that was enough. If we see that mobile apps and mabye standalone-server executables are added, we can create an org.

mkernel commented 7 years ago

Just my two cents watching from "the fence": as apps and webservice are often tied into each other and have requirements, we tend to use a single repository for all issues. However... you can't link to other repo's issues from commit messages.

So what we do in those cases (apps + webservice): use branches for each target which are not merged into each other and don't have a common history. Maybe that's an alternative on the way to setting up an organization.

dbeuchler commented 7 years ago

The idea of having an organization for the project is good. Have a look at haiwen/seafile https://github.com/haiwen

The server, apps and clients are seperate repositories. As @Toxantron said, it only makes sense if the development of apps is active.

Toxantron commented 7 years ago

Orphan branches are one alternative @mkernel. I suggested just splitting it into directories and later we can move the directory content to dedicated repos and use submodules.

mkernel commented 7 years ago

That'll also work, of course. But it has one disadvantage: pushes will be rejected by non-conflicting commits. In the end, every option works.

Toxantron commented 7 years ago

@mkernel thanks I was unaware of that. Just like the scaling ticket a while ago let's start small and scale with the needs later.

Toxantron commented 7 years ago

Multiple repos also makes sense if we want to start the asp.net version in a fresh repo.

faniereynders commented 7 years ago

@Toxantron I've created an organization - https://github.com/ScrumOnline and added you as owner. Let's see how this works out?

I can start drafting the initial repo layout.

Toxantron commented 7 years ago

You can start with a layout @faniereynders, but please understand I won't be moving to an org just yet. I first want to see where this goes and how a single repo scales before splitting it up. Regarding rights I already said after a couple of PRs I am happy to make you collaborators like @dbeuchler.

faniereynders commented 7 years ago

I absolutely understand and agree on your approach. This is baby steps. :)