search

Toxaris / pts

Interpreter for functional pure type systems.
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

Support GHC 7.10.2 #143

Closed mietek closed 8 years ago

mietek commented 8 years ago

The next step would be dealing with the following:

src-lib/Control/Monad/Errors/Class.hs:18:21: Warning:
    In the use of type constructor or class ‘Error’
    (imported from Control.Monad.Error.Class, but defined in Control.Monad.Trans.Error):
    Deprecated: "Use Control.Monad.Trans.Except instead"
src-lib/Control/Monad/Errors.hs:7:1: Warning:
    Module ‘Control.Monad.Error’ is deprecated:
      Use Control.Monad.Except instead
Blaisorblade commented 8 years ago

Hey, you again? (We talked about Halcyon, and about some PL stuff, months ago). Thanks for the PR! :+1: Since this patch does not remove support for any compiler (and tests still pass on 7.10), merging! :smile:

Regarding the deprecation warning you mention: both I and @Toxaris are rather busy and this has unfortunately low priority. More importantly, Control.Monad.Trans.Except doesn't exist in the previous Haskell Platform (2014.2.0.0) out-of-the-box, unless you install another transformers on top. :scream: That would probably become moot if we switched to stack (or with sandboxes), but we haven't discussed that yet.

Blaisorblade commented 8 years ago

Control.Monad.Trans.Except doesn't exist in the previous Haskell Platform

FTR: Michael Snoyman pointed out transformers-compat exists exactly to solve this problem, and using it is probably little work.