search

Toxblh / youtube-speed-control

MIT License
23 stars 9 forks source link

buttons doesn't respect WCAG contrast recommendations #2

Closed 532910 closed 4 years ago

532910 commented 4 years ago

image

https://webaim.org/resources/contrastchecker/?fcolor=666666&bcolor=333333 https://contrastchecker.com/?c=1081b2&b=17a0db

Toxblh commented 4 years ago

Sorry, that is bug of your theme. By standard is grey on white https://webaim.org/resources/contrastchecker/?fcolor=666666&bcolor=333333 which is almost pass image

532910 commented 4 years ago

No it your bug! You must never define only one color. Both fg and bg must be defined together or not defined at all.

532910 commented 4 years ago

Moreover, it's the default dark theme, not a custom one.

Toxblh commented 4 years ago

Please send to me a link to the default dark theme.

532910 commented 4 years ago

What link are you talking about? It comes with browser.

Toxblh commented 4 years ago

So, I use the same, I hope, default dark theme image But that is doesn't change colors on option page. Anyway I will change to more contrast color. But I can't to check how you receive the result of compute colors to dark

532910 commented 4 years ago

Try to set widget.content.allow-gtk-dark-theme or browser.display.use_system_colors with $GTK_THEME=Adwaita:dark

The whole ff should be dark: image

Toxblh commented 4 years ago

Did it all. Settings of browser and really stay dark. But not option page. Anyway. I'll just recreate the option page with more standard approach. Thank you for your time and issue

Toxblh commented 4 years ago

Yes found, needed to reload in new tab image Got it. Thanks again

532910 commented 4 years ago

I confirm it looks fine now, thank you!