Closed zebralt closed 3 years ago
This is one impressive PR. Highly readable codes, proper comments. Appreciate this PR. Just one correction, you missed embedding one of the commands ( setdays ).
Thanks for your kind words :) Here, I added the missing embed conversions.
Thank you for your contribution. All the best.
Description
19
The module
helper/embed.py
provides helper functions to convert string messages into Embeds. In addition to the base caseas_embed(text: str) -> Embed
, this PR provides a few options to make messages more meaningful by styling the output Embed, not unlike log levels:embed.info
for a message with no particular severity (help, initialization details);embed.error
for error messages (e.g. missing command parameters);embed.success
for messages expressing success in performing a command.I used these to convert all
(channel|ctx).send
calls so that they send an Embed element to Discord instead of a raw string, as #19 was suggesting.I used the helpful https://leovoel.github.io/embed-visualizer/ to make sure the Embeds looked right & test the functions in
helper/embed.py
.Have you read the Contributing Guidelines on Pull Requests?
Type of change