search

ToxicFrog / Ligaturizer

Programming Fonts with Ligatures added (& a script to add them to other fonts)
GNU General Public License v3.0
2.19k stars 112 forks source link

M+ fonts do not rename, and collide with the originals. #58

Closed DevotionGeo closed 5 years ago

DevotionGeo commented 5 years ago

M+ 1m and M+ 1mn fonts don't rename. When I opened the fonts in FontForge and looked at the Font info, the name have the 'Liga' prefix, but when I open the same font in font viewer it doesn't have the prefix, and while using inside VSCode it activates with the original name (overriding the original) instead of activating with the prefixed name.

screenshot from 2019-01-08 05-21-58

screenshot from 2019-01-08 05-22-39

I also added the following to the prefixed_fonts array (but the problem retained).

  'fonts/codeface/fonts/mplus1m/*.ttf',
  'fonts/codeface/fonts/mplus1mn/*.ttf',
oganm commented 5 years ago

The same is true for ubuntu mono at least

Avi-D-coder commented 5 years ago

IBM plex as well

ToxicFrog commented 5 years ago

Huh. For me, IBM Plex Mono shows up just fine (as Ligalex Mono), but Ubuntu Mono does not. They have the correct familyname and fullname, and the Family, UniqueID, and Fullname in sfnt_names are also correct.

The only suspicious things I see are these entries in sfnt_names for Ubuntu Mono:

('English (US)', 'Preferred Family', 'Ubuntu Mono')
('English (US)', 'Compatible Full', 'Ubuntu Mono')

And in Plex:

('English (US)', 'Preferred Family', 'IBM Plex Mono')

I wonder if the Preferred Family is overriding the other settings.

ToxicFrog commented 5 years ago

Yep, that's the problem. Should have a fix later today, hopefully.

ToxicFrog commented 5 years ago

This should hopefully be fixed by 6d3070ae1c6b1a6ec196db486be813d713c7ce9c.