search

ToxicFrog / Ligaturizer

Programming Fonts with Ligatures added (& a script to add them to other fonts)
GNU General Public License v3.0
2.19k stars 112 forks source link

Removing of "fi" and "fl" ligatures from the generated font #59

Closed xpl closed 2 years ago

xpl commented 5 years ago

These ligatures are unwanted and make the code look crippled in VSCode with ligatures enabled:

screen shot 2019-01-12 at 00 14 16

Fortunately, it is quite easy to remove them from the generated font.

ToxicFrog commented 5 years ago

This has come up before, in #41 -- those ligatures aren't installed by Ligaturizer, they're present in the original font. I'm reluctant to unilaterally remove them because, presumably, if someone is using a font with those ligatures in it as the basis, it's because they like that font. This might make sense to have as an option, though, or as a separate script people can run.

What font are you using?

xpl commented 5 years ago

@ToxicFrog I'm using the default Monaco on my OS X, it is a system font.

if someone is using a font with those ligatures in it as the basis, it's because they like that font

I like Monaco, but do not like these ligatures (as they break the formatting and make the code look ugly). I am quite certain that nobody needs these in a monospaced programming font. These ligatures only come up when one enables ligatures in the editor's settings, as they are disabled by default...

At least, you could introduce a command line option that will enable the removal of these ligatures! Better to be a command line option than a separate script.

qm3ster commented 5 years ago

Just curious, what is the red arrow on the right pointing at? Did it make the line shorter?

xpl commented 5 years ago

@qm3ster Yes, it made the line shorter.

marcinlesek commented 5 years ago

@xpl this change didn't work for me, unfortunately. Created font couldn't be loaded to Mojave MacOS, Font Book could do it and don't show any error. Manually coping it to Fonts directory also didn't work.

Anyone had similar problem? 🤔

drakeet commented 4 years ago

@xpl This PR works for me, GREAT! I don't like the liga fi & fl, too, and now they are removed after pulling your this commit. Thank you so much!

image (It's a Liga Menlo, lol)

marcinlesek commented 4 years ago

@drakeet could you upload your Liga Menlo with fixed fi and fl ligatures, please?

drakeet commented 4 years ago

@marcinlesek I'm not sure if this is legal because my Menlo is derived from Apple's Mac system and I don't know if it is open source or allows sharing.🤔

drakeet commented 4 years ago

@marcinlesek The key is you should convert the TTC to TTF first: https://transfonter.org/ttc-unpack

marcinlesek commented 4 years ago

@drakeet I'm working on MacBook also 😉 If you could provide some guide how to do it step by step I'll be obligated. 🙏

drakeet commented 4 years ago

@marcinlesek You can copy the Menlo from you mac path /System/Library/Fonts/Menlo.ttc, and use the https://transfonter.org/ttc-unpack to convert the TTC to TTFs, then copy the fonts to the dir of this Ligaturizer, and follow its usage steps (https://github.com/ToxicFrog/Ligaturizer#using-the-script).

image

marcinlesek commented 4 years ago

@drakeet Got this now! Works for me! Thank you all! 🙏

ToxicFrog commented 3 years ago

Glad you found a workaround!

It hadn't occurred to me that people might be using fonts that have ligatures, but are usually only used with ligatures off, thus revealing problems when ligatures are turned on; I don't know if the solution in this patch will generalize to every font with these ligatures, but I'll see about adding it as a configuration file option.

rojiani commented 2 years ago

Closing this PR since there seems to be a workaround

jonesnc commented 2 years ago

Could this functionality be enabled with an optional flag?