search

ToxicFrog / Ligaturizer

Programming Fonts with Ligatures added (& a script to add them to other fonts)
GNU General Public License v3.0
2.23k stars 114 forks source link

Bump to Fira v4 #86

Closed H12 closed 4 years ago

H12 commented 4 years ago

This bumps the Fira Code submodule to the version 4 release tag commit, the hash for which is d42e7276fa925e5f82748f3ec9ea429736611b48.

I ran make with all the base fonts and ligatures enabled, and did not see any errors in the output. Not sure whether there's any other testing I should do, but as of now this appears to be a pretty painless bump.

Let me know if anything looks off!

Resolves #85

MrJmpl3 commented 4 years ago

Now, Fira Code have v4.

H12 commented 4 years ago

Thanks @MrJmpl3! I've updated this PR to the Fira v4 release commit.

Angalexik commented 4 years ago

This bump breaks all arrow and markdown header ligatures

H12 commented 4 years ago

Thanks, @Angalexik, that makes sense. Fira v4 now supports arbitrarily-long ligatures, which don't seem compatible with the way this project was built.

After looking into it, I don't think a simple bump would be particularly useful, and I'm not a strong enough Python dev to know how to fill the gaps.

Because of this, I'm closing this PR.