Toxicom / toxiui

ToxiUI is a plugin for ElvUI in World of Warcraft
Other
24 stars 14 forks source link

release.json asset lost between v6.7.3-beta.1 and v6.7.3-beta.2 #115

Closed torkus closed 2 months ago

torkus commented 2 months ago

Description

The release.json release asset appears to have disappeared started at release v6.7.3-beta.2

Toxicom commented 2 months ago

release.json is generated automatically, I haven't changed anything in the packager. Why do you need it?

torkus commented 2 months ago

I maintain a catalogue of wow addons available on Github for my addon manager Strongbox. The catalogue is regenerated weekly and I noticed that the presence of the release.json file disappeared, which is unusual.

The release.json file is preferred to scraping a Github release as it is less expensive to download and probably more accurate.

I think I tracked the problem down to your fork of the packager script, it's a little out of date: Screenshot at 2024-07-27 08-30-08

Here is the release job with the warning and errors: https://github.com/Toxicom/toxiui/actions/runs/10073080732/job/27846430418

And this is the interesting line: https://github.com/Toxicom/toxiui/actions/runs/10073080732/job/27846430418#step:4:42

/home/runner/work/_actions/Toxicom/packager/master/release.sh: line 1220: printf: 110000,11: invalid number

Which eventually leads to: https://github.com/Toxicom/toxiui/actions/runs/10073080732/job/27846430418#step:4:1000

There was an error creating release.json

Toxicom commented 2 months ago

I see, I'll try updating

Toxicom commented 2 months ago

I've updated our packager

I believe the issue occured because I introduced multiple versions TOC and the old packager did not support it.

torkus commented 2 months ago

thanks for taking a look @Toxicom

Toxicom commented 2 months ago

release.json is back in v6.7.6-beta.1