search

Toxicom / toxiui

ToxiUI is a plugin for ElvUI in World of Warcraft
Other
24 stars 14 forks source link

ActionButtonUseKeyDown cvar (required for GSE) breaks clcikable Wunderbae modules #135

Closed wccropper closed 4 weeks ago

wccropper commented 4 weeks ago

Description

I use GSE and with v11.0 it changed it so for GSE macros to work they require the cvar to be ActionButtonUseKeyDown be false. This breaks several of Wunderbar's modules. MicroMenu, Currency, Hearthstone

Lua error

no error. clicking many of the Wunderbar modules do nothing.

ToxiUI Status Report

image

To reproduce

Change the cvar and try clicking on one of the above modules.

Toxicom commented 4 weeks ago

We're not changing this behavior. Key down is objectively better.

Toxicom commented 4 weeks ago

Actually was able to come up with a compromise where both parties are happy. Changed WunderBar's click registering to check for the CVar and based on that register either AnyDown or AnyUp

From my brief testing seems to work, let me know how it goes. https://github.com/Toxicom/toxiui/commit/06191e5ebc187c4b0c9d34007bf70eeeda338d90

wccropper commented 4 weeks ago

Ho do I easily get these changes into my install?

Toxicom commented 4 weeks ago

Either clone the git repository, or wait for the v6.8.4-beta.1 release that I'm currently deploying.

Toxicom commented 4 weeks ago

https://github.com/Toxicom/toxiui/releases/tag/v6.8.4-beta.1

wccropper commented 4 weeks ago

I will wait and reply back! You are an amazing dev. By far my favorite ElvUI edit ever. Donation incoming!

wccropper commented 4 weeks ago

Yeah, all working. Thanks again!

Toxicom commented 4 weeks ago

Nice :)