search

ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
213 stars 52 forks source link

Pause when switching output channel #17

Open SammysHP opened 10 months ago

SammysHP commented 10 months ago

This allows to select the maximum regulated level when ramping up or down.

SiteRelEnby commented 10 months ago

I feel like I'm missing what this actually does other than set and then decrement a variable - just adding a delay when ramping down? delay_zero() might be easier, but also this seems like it'd apply every single time the user ramps down rather than just if you meant e.g. on the border between a linear vs FET ramp segment?

SammysHP commented 10 months ago

This stops for HOLD_TIMEOUT when ramping up and down every time you cross the channel switchover. This allows the user to precisely select the maximum regulated level while ramping. Without it, BLINK_AT_RAMP_MIDDLE is pretty useless.

ToyKeeper commented 10 months ago

This is an interesting option, but I don't plan to enable it by default (i.e. in production builds). It seems more appropriate as a thing people can enable at compile time, like by setting a preference in users/$myuser/ so it'll apply to all their builds.

SammysHP commented 10 months ago

It's enough to comment out the line in config-default.h to make it optional. Should I update the pull request accordingly?