ToyKeeper / anduril

Anduril 2 Flashlight Firmware and FSM UI Toolkit
GNU General Public License v3.0
213 stars 52 forks source link

Add configurable aux LED channel #19

Open SammysHP opened 10 months ago

SammysHP commented 10 months ago

For an older version of Anduril I started to implement a new channel that allows the user to select the aux color:

https://github.com/SammysHP/flashlight-firmware/compare/multi-channel...mc-auxmix-channel

Instead of having seven additional channels, one for each color, there would be only one channel with 3H changing the color. It also included some changes to allow to overwrite the number of steps, so that it doesn't conflict with tint ramping steps or alignment.

In the current state it cannot be applied and it could also need some improvements like:

SiteRelEnby commented 10 months ago

The main problem I see with this one is how it affects blinky modes (would need code changes). I use the aux channels on some lights as a ramp mode channel, but I don't want the blinky mode colour to change every time I do.

Would be possible to just add a new EEPROM var for something like aux_channel_blink_arg and save it independently when the user does a 3C in battcheck mode, I guess (or just 3C to aux mode, then 3H to adjust arg which is just saved separately, might be simpler).